]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
quickSettings: Override StButton:label property
authorFlorian Müllner <fmuellner@gnome.org>
Mon, 22 Aug 2022 23:30:18 +0000 (01:30 +0200)
committerMarge Bot <marge-bot@gnome.org>
Wed, 31 Aug 2022 16:40:30 +0000 (16:40 +0000)
StButton already has a :label property, so we should override it
instead of shadowing it with a new property of the same name, like
we already do for :icon-name.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2462>

js/ui/quickSettings.js

index faa87601fc770fbd7726713d33c21532f4f1dbe8..822893b782fbef5fc341ba2b41413338dbcf27dc 100644 (file)
@@ -34,13 +34,11 @@ var QuickSettingsItem = GObject.registerClass({
 
 var QuickToggle = GObject.registerClass({
     Properties: {
+        'label': GObject.ParamSpec.override('label', St.Button),
         'icon-name': GObject.ParamSpec.override('icon-name', St.Button),
         'gicon': GObject.ParamSpec.object('gicon', '', '',
             GObject.ParamFlags.READWRITE,
             Gio.Icon),
-        'label': GObject.ParamSpec.string('label', '', '',
-            GObject.ParamFlags.READWRITE,
-            ''),
     },
 }, class QuickToggle extends QuickSettingsItem {
     _init(params) {